|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] draft-ietf-ips-scsi-mib-04 comments
Comments on draft-ietf-ips-scsi-mib-04:
Technical:
=========
COMMENT: For a logical unit in a multiple ported device, the ScsiLuIdentifier cannot return a scsiLuIdAssociation of type "port" (01 binary) because the target port being used to access the logical unit is not known. (The MIB is probably being retrieved through a non-SCSI channel... which target port does the logical unit pick?)
For this version of the MIB, I'd just require that scsiLuIdAssociation be set to 0 (or possibly 2) and figure out how to report target-port specific information in the future.
This occurs in the ScsiIdAssociation textual-convention and in the parallel SCSI example:
" ScsiIdAssociation ::= TEXTUAL-CONVENTION
STATUS current
DESCRIPTION
"This Textual Convention specifies what the identifier is
associated with (e.g, with the addressed physical/logical
device or with a particular port) for the identifier contained
in an Identification Descriptor returned in a Logical Unit's
Device Identification Page, and is formatted as defined in T10
SPC-2 (see REFERENCE) table 178 û Association." "
and:
" 11.14 scsiLuIdentifer:
Attribute Value
---------- ------
scsiInstIndex 1
scsiDeviceIndex 2
scsiLuIndex 1
scsiLuIdIndex 1
scsiLuIdCodeSet *1 2
scsiLuIdAssociation *2 1
scsiLuIdType *3 1
scsiLuIdValue IETFsl318203-0004
*1 - The identifier field will have ASCII graphic codes.
*2 - The identifier is associated with the port that received the
request. "
Change the example value to 0 and remove note 2.
Also note that SPC-3 is changing 0 to mean "logical unit" rather than
"physical/logical device" and 1 to mean "target port". It is also
adding 2 as "target device" (which could be reported through this
MIB).
Mostly editorial:
================
4.9 The LUN Map Statistics High Speed Group
"Managed systems acting, as a target device and port, able to gather statistics on remote initiator devices or ports and running at high speed should implement this group."
COMMENT: The commas should be removed in this sentence and "and" should be added before "able".
4.13 The Discovery Statistics High Speed Group
"Managed systems acting, as an initiator device and port, able to gather statistics on remote target devices or ports and running at high speed should implement this group."
COMMENT: Remove the commas and add "and" before "able".
5. Relationships in this MIB
"This should prevent a SCSI initiator device or port to attach to SCSI target devices, which should be either invisible or inaccessible to it."
COMMENT: Change "to attach" to "from attaching" and remove the command before "which".
"The information, for the aforementioned SCSI target ports or SCSI target devices, about the LUNs and their respective LUN Ids should be provided."
COMMENT: This seems to be confusing logical unit and logical unit number, then creating a LUN Id as another level. It should read "...the LUs and their respective LUNs..."
"This list should feature the concept of æaccess listsÆ, which are common in IP routers and switches."
COMMENT: Contains non-ASCII text characters before and after access lists.
7.3 State of logical units
"For more information on the logical unit states see the SCSI Controller Commands-2 (SCC-2) standard (NCITS.318-1998)"
COMMENT: Lacks a period at the end of the sentence.
9. Object Definitions
" ScsiIdentifier ::= TEXTUAL-CONVENTION
STATUS current
DESCRIPTION
"This Textual Convention represents a generic SCSI device or
port identifier.
The format depends on the transport used:
- SPI: only bits:0-3 for a port identifier (LSB is 0 and MSB
is 3). Other bits must be zero. "
COMMENT: Using network bit ordering, I think you want 0 to be the MSB and 3 to be the LSB.
" - iSCSI: 256 bytes for a device identifier.
- iSCSI: 258 bytes for a target port identifier.
- iSCSI: 262 bytes for an initiator port identifier.
...
REFERENCE
" T10 - Names, Addresses, Identifiers, Oh my! - George
Penokie - 01-084r6."
SYNTAX OCTET STRING (SIZE (0..262)) "
COMMENT: The iSCSI name lengths were shortened by iSCSI revision 16 to not exceed 255 bytes.
SAM-3 revision 2 incorporated "02-348r0 SAM-3 Names and Identifiers for iSCSI revision 16" to reflect this. In the future, a few more bytes might be chopped off by 02-419 Device names and VPD data. In the interim, a few extra in the MIB shouldn't hurt.
Either make the iSCSI identifiers all 255 bytes or:
device name 224 (including NULL)
initiator port name 245 (including NULL)
target port name 233 (including NULL)
In either case, make the maximum octet string 255 not 262.
Additionally, clarify if the NULL is always included or not included in the octet string.
Change the REFERENCE to SAM-3, not the old T10 proposal 01-084, and drop reference 17 from the document (to 01-084).
" ScsiIdAssociation ::= TEXTUAL-CONVENTION
STATUS current
DESCRIPTION
"This Textual Convention specifies what the identifier is
associated with (e.g, with the addressed physical/logical
device or with a particular port) for the identifier contained
in an Identification Descriptor returned in a Logical Unit's
Device Identification Page, and is formatted as defined in T10
SPC-2 (see REFERENCE) table 178 û Association." "
COMMENT: A non-ASCII character follows "178 ".
" REFERENCE
" T10 - SCSI Parallel Interface - 4 (SPI-4) - #1365-D
Rev [10]" "
COMMENT: This is through INCITS and at ANSI; it will be INCITS.362.
" REFERENCE
"T10 - SCSI RDMA Protocol (SRP) - #1415-D Rev [16]."
::= { scsiTransportTypes 4 } "
COMMENT: 16a is the latest version, currently at INCITS. It will be INCITS .365.
" REFERENCE
"IETF IPS Working Group û draft-ietf-ips-iscsi-14.txt"
::= { scsiTransportTypes 5 } "
COMMENT: This should be -19 or possible an RFC. There is a non-ASCII character after "Group ".
" scsiIntrPrtHSOutCommands OBJECT-TYPE
SYNTAX Counter64
UNITS "commands"
MAX-ACCESS read-only
STATUS current
DESCRIPTION
"This object represents the number of commands sent by this
initiator device. This object provides support for systems
which can quickly generate lots of commands because they run
at high speed port." "
COMMENT: I don't understand "they run at high speed port".
" scsiDscLunTable OBJECT-TYPE
SYNTAX SEQUENCE OF ScsiDscLunEntry
MAX-ACCESS not-accessible
STATUS current
DESCRIPTION
"This table includes all the remote (not in the local system)
logical unit numbers (LUNS) discovered via each local
initiator port of each local device within a particular SCSI
instance." "
COMMENT: LUNS should be LUNs.
" scsiDscLunIndex OBJECT-TYPE
SYNTAX ScsiIndexValue
MAX-ACCESS not-accessible
STATUS current
DESCRIPTION
"This object is an arbitrary integer used to uniquely
identify a particular LUN discovered by a particular scsi
initiator port or a particular SCSI initiator device within a
particular SCSI instance. Entries in the scsiDscLunIdTable
are associated with a LUN by having the value of this object
in their INDEX." "
COMMENT: scsi should be SCSI.
" scsiDscLunIdIndex OBJECT-TYPE
SYNTAX ScsiIndexValue
MAX-ACCESS not-accessible
STATUS current
DESCRIPTION
"This object is an arbitrary integer used to uniquely
identify a particular LUN Identifier discovered by each scsi
initiator device or particular SCSI initiator port within a
particular SCSI instance."
::= { scsiDscLunIdEntry 1 } "
COMMENT: scsi should be SCSI.
" -- The scsiAuthorizedIntrTable contains the list of remote initiator
-- ports that are authorized to be attached specific target ports
-- and on which, an administrator would like to keep permanent
-- information and long term statistics even when not currently
-- attached. "
COMMENT: Remove comma after which.
" scsiLuTable OBJECT-TYPE
SYNTAX SEQUENCE OF ScsiLuEntry
MAX-ACCESS not-accessible
STATUS current
DESCRIPTION
" This table contains all the logical units exposed by local
target devices.
It includes attributes for the WWN, scsiLuVendorId,
scsiLuProductId and scsiLuRevisionId. The WWN and the group
of scsiLuVendorId, scsiLuProductId, scsiLuRevisionId are
represented each in a block. The scsiLuIdTable may include
each of those two blocks according to the LUIdType. Not every
LU must have a those attributes (e.g. WWN), but each LU can
have only one single value for any of those attributes.
Therefore in the case that one or more entries in the
scsiLuIdTable provide either the WWN or the group of
scsiLuVendorId, scsiLuProductId, scsiLuRevisionId, the values
of those MUST be identical to those provided in the
scsiLUTable "
::= { scsiLogicalUnit 1 } "
COMMENT: Remove "a" before "those"
" scsiLuVendorId OBJECT-TYPE
SYNTAX SnmpAdminString(SIZE(0..79))
MAX-ACCESS read-only
STATUS current
DESCRIPTION
" This object represents a string identifying the vendor of
this LU according to the value in SCSI device page."
::= { scsiLuEntry 4 } "
COMMENT: What is a "SCSI device page"? I think this means "this LU as
reported in the Standard INQUIRY data".
The same comment applies to the descriptions of scsiLuProductId and
scsiLuRevisionId.
" scsiLuPeripheralType OBJECT-TYPE
SYNTAX Unsigned32
MAX-ACCESS read-only
STATUS current
DESCRIPTION
"This object is the value returned to SCSI query VPD page 83.
It can be: direct-access device, sequential-access device,
printer, communication device and so on.
The values that can be returned here are defined in SCSI
Primary Commands -2." "
COMMENT: The peripheral device type field is in Standard INQUIRY data, not
VPD page 83h.
" SYNTAX Counter32
UNITS "resets"
MAX-ACCESS read-only
STATUS current
DESCRIPTION
" This object represents the number of resets received by
this logical unit."
::= { scsiLuEntry 13 } "
COMMENT: What does "reset" mean? SAM-3 defines four kinds: power on, hard reset,
logical unit reset, and I_T nexus loss. I suspect that logical unit reset is
intended.
" scsiLuOutQueueFullStatus OBJECT-TYPE
SYNTAX Counter32
MAX-ACCESS read-only
STATUS current
DESCRIPTION
" This object represents the number of queue full statuses
received by this logical unit."
::= { scsiLuEntry 14 } "
COMMENT: There is no QUEUE FULL in SCSI-3; that's a SCSI-2 term. Use
"TASK SET FULL".
" [14] Information Technology, SCSI Architecture Model-2 (SAM-2), Working Draft, T10
Project 1157-D, Revision 20, 19 September 2001 "
COMMENT: Drop "Information Technology" from all the T10 references.
--
Rob Elliott, elliott@hp.com
Hewlett-Packard Industry Standard Server Storage Advanced Technology
https://ecardfile.com/id/RobElliott
Home Last updated: Tue Dec 10 11:19:07 2002 12072 messages in chronological order |